On Thu, 10 Feb 2022, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > On Tue, 08 Feb 2022, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: >> Another collection of cleanup patches for intel_gt_regs.h to make it a >> bit less painful to work with. > > I didn't review this but I agree with what's being done. > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> PS. We somehow ended up with both _reg.h and _regs.h. Would be nice to settle on one or the other. Which one? BR, Jani. > >> >> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> >> >> Matt Roper (6): >> drm/i915/gt: Drop duplicate register definition for VDBOX_CGCTL3F18 >> drm/i915/gt: Move SFC lock bits to intel_engine_regs.h >> drm/i915/gt: Use parameterized RING_MI_MODE >> drm/i915/gt: Cleanup spacing of intel_gt_regs.h >> drm/i915/gt: Use consistent offset notation in intel_gt_regs.h >> drm/i915/gt: Order GT registers by MMIO offset >> >> drivers/gpu/drm/i915/gt/intel_engine_regs.h | 23 + >> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2623 +++++++++---------- >> drivers/gpu/drm/i915/gt/intel_reset.c | 14 +- >> drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +- >> drivers/gpu/drm/i915/intel_uncore.c | 2 +- >> 5 files changed, 1333 insertions(+), 1335 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center
