On Tue, 08 Feb 2022, Namhyung Kim <namhyung@xxxxxxxxxx> wrote: > Hello, > > On Tue, Feb 8, 2022 at 10:51 AM Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: >> >> On Tue, 08 Feb 2022, Namhyung Kim <namhyung@xxxxxxxxxx> wrote: >> > With upcoming lock tracepoints config, it'd define some of lockdep >> > functions without enabling CONFIG_LOCKDEP actually. The existing code >> > assumes those functions will be removed by the preprocessor but it's >> > not the case anymore. Let's protect the code with #ifdef's explicitly. >> >> I don't understand why you can't keep the no-op stubs for >> CONFIG_LOCKDEP=n. > > Because I want to use the lockdep annotation for other purposes. > But the workqueue lockdep_map was defined under LOCKDEP > only. Please see the description in the cover letter. > > https://lore.kernel.org/all/20220208184208.79303-1-namhyung@xxxxxxxxxx/ So lockdep_init_map() might still be there and build just fine for CONFIG_LOCKDEP=n, but now we're actually required to wrap all call sites in #ifdefs depending on the purpose? I'm not convinced yet. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
