On Thu, Feb 03, 2022 at 04:02:27PM +0200, Jani Nikula wrote: > Group the forward declarations in i915_drv.h together near the top, like > in other header files, and sort. > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_drv.h | 44 ++++++++++++++------------------- > 1 file changed, 19 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 8c1706fd81f9..5a1615c02971 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -106,6 +106,25 @@ > #include "gt/intel_timeline.h" > #include "i915_vma.h" > > +struct dpll; > +struct drm_i915_gem_object; > +struct drm_i915_private; > +struct intel_atomic_state; > +struct intel_audio_funcs; > +struct intel_cdclk_config; > +struct intel_cdclk_funcs; > +struct intel_cdclk_state; > +struct intel_cdclk_vals; We're already including intel_cdclk.h so these shouldn't even be needed. Apart from that Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> -- Ville Syrjälä Intel