== Series Details == Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev2) URL : https://patchwork.freedesktop.org/series/99711/ State : warning == Summary == $ dim checkpatch origin/drm-tip 80cfc4e5862f iosys-map: Add offset to iosys_map_memcpy_to() 2997557ba29b iosys-map: Add a few more helpers -:106: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'map_' may be better as '(map_)' to avoid precedence issues #106: FILE: include/linux/iosys-map.h:157: +#define IOSYS_MAP_INIT_OFFSET(map_, offset_) ({ \ + struct iosys_map copy = *map_; \ + iosys_map_incr(©, offset_); \ + copy; \ +}) -:261: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_offset__' may be better as '(struct_offset__)' to avoid precedence issues #261: FILE: include/linux/iosys-map.h:433: +#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \ + struct_type__ *s; \ + iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \ + typeof(s->field__)); \ +}) -:261: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_type__' may be better as '(struct_type__)' to avoid precedence issues #261: FILE: include/linux/iosys-map.h:433: +#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \ + struct_type__ *s; \ + iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \ + typeof(s->field__)); \ +}) -:261: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field__' - possible side-effects? #261: FILE: include/linux/iosys-map.h:433: +#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \ + struct_type__ *s; \ + iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \ + typeof(s->field__)); \ +}) -:282: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_offset__' may be better as '(struct_offset__)' to avoid precedence issues #282: FILE: include/linux/iosys-map.h:454: +#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \ + struct_type__ *s; \ + iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \ + typeof(s->field__), val__); \ +}) -:282: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_type__' may be better as '(struct_type__)' to avoid precedence issues #282: FILE: include/linux/iosys-map.h:454: +#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \ + struct_type__ *s; \ + iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \ + typeof(s->field__), val__); \ +}) -:282: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field__' - possible side-effects? #282: FILE: include/linux/iosys-map.h:454: +#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \ + struct_type__ *s; \ + iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \ + typeof(s->field__), val__); \ +}) total: 0 errors, 0 warnings, 7 checks, 224 lines checked 342e2b55298e drm/i915/gt: Add helper for shmem copy to iosys_map 75652221ece7 drm/i915/guc: Keep iosys_map of ads_blob around e909c8680cf3 drm/i915/guc: Add read/write helpers for ADS blob 3f919b8d697b drm/i915/guc: Convert golden context init to iosys_map dab9247a24d0 drm/i915/guc: Convert policies update to iosys_map 46fcb66d43f0 drm/i915/guc: Convert engine record to iosys_map 2edec322d581 drm/i915/guc: Convert guc_ads_private_data_reset to iosys_map 550662116c5a drm/i915/guc: Convert golden context prep to iosys_map ceddc2cf4b84 drm/i915/guc: Replace check for golden context size 658eb1647538 drm/i915/guc: Convert mapping table to iosys_map 91176455914b drm/i915/guc: Convert capture list to iosys_map 4c99355845f0 drm/i915/guc: Prepare for error propagation a65c1205676e drm/i915/guc: Use a single pass to calculate regset 67c37ac3868b drm/i915/guc: Convert guc_mmio_reg_state_init to iosys_map ff9c86ae5eea drm/i915/guc: Convert __guc_ads_init to iosys_map -:42: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #42: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:623: + ads_blob_write(guc, system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK], -:52: WARNING:LONG_LINE: line length of 111 exceeds 100 columns #52: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:630: + system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI], total: 0 errors, 2 warnings, 0 checks, 52 lines checked 692f09e09c1c drm/i915/guc: Remove plain ads_blob pointer
