On Mon, 07 Feb 2022, Christoph Hellwig <hch@xxxxxx> wrote: > On Mon, Feb 07, 2022 at 06:57:13AM -0500, Zhi Wang wrote: >> Hi Christoph and Jani: >> >> Thanks for the comments. It would be nice that people can achieve a >> agreement. I am OK with both of the options and also moving some files into >> different folders doesn't needs me to do the full test run again. :) > > The way I understood Jani he agrees that the mmio table, which needs to > be part of the core i915 module should not be under the gvt/ subdiretory. > I.e. it could be drivers/gpu/drm/i915/intel_gvt_mmio_table.c. The > declarations could then go either into drivers/gpu/drm/i915/intel_gvt.h > or drivers/gpu/drm/i915/intel_gvt_mmio_table.h. Correct. Generally I prefer to have the declarations for stuff in intel_foo.c to be placed in intel_foo.h, and named intel_foo_*. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
