On Sun, Jun 9, 2013 at 11:01 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote: > On Sun, Jun 09, 2013 at 09:48:11PM +0200, Daniel Vetter wrote: >> On Sun, Jun 9, 2013 at 7:23 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote: >> > The pixel multiplier is only stored in SDVOX on i915g/i915gm, so we need >> > to use the value retreived from the card for pipe_config and restrict >> > the cross check to i915g/i915gm. >> > >> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk> >> >> Failing this cross check was a fallout from the incosistent ordering >> of the get_pipe_config vs. encoder->get_config calls in setup_hw_state >> vs. modeset_check_state. It should be fixed in latest dinq, at least >> it seemed to on my g33 and i915g. > > It is not fixed as of: > > commit 22e407d749a418b4bb4cc93ef76e0429a9f83c82 > Author: Ville Syrj?l? <ville.syrjala at linux.intel.com> > Date: Fri Jun 7 18:52:24 2013 +0300 > > drm/i915: Make g4x_fixup_plane() operational again Hm, indeed something seems to be amiss. I'll check this out, since it's supposed to work ... dunno what I've missed in testing :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
