Re: [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 02 Feb 2022, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
>> I dropped the ball here a bit. If I respin the same patches, but with
>> the above line changed to one of these, is it okay? Which do you prefer?
>> 
>> 1)	outb(VGA_SEQ_CLOCK_MODE, VGA_SEQ_I); /* SR01 */
>> 
>> 2)	#define SR01 VGA_SEQ_CLOCK_MODE
>> 	outb(SR01, VGA_SEQ_I);
>> 
>> 3)	outb(0x01, VGA_SEQ_I);
>
> 3 seems like the best option of these.

Thanks, v2 on the list.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux