On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote: > On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote: > > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote: > > > This "ret" declaration shadows an existing "ret" variable at the > > > top of > > > the function. Delete it. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > > > and pushing right now > > Should probably have had a Fixes: tag on this one. I'm not 100% sure > whether the faulty patch is already upstream. In that case we might > need to manually include it in a -fixes pull. > It's not really a bug. It's just a Sparse warning which is disabled by default (-Wshadow). The patch is in linux-next. Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") regards, dan carpenter