> -----Original Message----- > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Wednesday, January 26, 2022 20:06 > To: Usyskin, Alexander <alexander.usyskin@xxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Joonas Lahtinen > <joonas.lahtinen@xxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; > David Airlie <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Winkler, > Tomas <tomas.winkler@xxxxxxxxx>; Lubart, Vitaly <vitaly.lubart@xxxxxxxxx>; > intel-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/5] mei: add support for graphics system controller > (gsc) devices > > On Wed, Jan 19, 2022 at 05:58:04PM +0200, Alexander Usyskin wrote: > > From: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > > > GSC is a graphics system controller, based on CSE, it provides > > a chassis controller for graphics discrete cards, as well as it > > supports media protection on selected devices. > > > > mei_gsc binds to a auxiliary devices exposed by Intel discrete > > driver i915. > > > > Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx> > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > --- > > drivers/misc/mei/Kconfig | 14 +++ > > drivers/misc/mei/Makefile | 3 + > > drivers/misc/mei/gsc-me.c | 192 > ++++++++++++++++++++++++++++++++++++++ > > drivers/misc/mei/hw-me.c | 27 +++++- > > drivers/misc/mei/hw-me.h | 2 + > > 5 files changed, 236 insertions(+), 2 deletions(-) > > create mode 100644 drivers/misc/mei/gsc-me.c > > > > diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig > > index 0e0bcd0da852..ec119bb98251 100644 > > --- a/drivers/misc/mei/Kconfig > > +++ b/drivers/misc/mei/Kconfig > > @@ -46,6 +46,20 @@ config INTEL_MEI_TXE > > Supported SoCs: > > Intel Bay Trail > > > > +config INTEL_MEI_GSC > > + tristate "Intel MEI GSC embedded device" > > + select INTEL_MEI > > + select INTEL_MEI_ME > > Please don't select, why not just depend on? These are hard dependencies. If user wants to have INTEL_GSC, user should enable INTEL_MEI and INTEL_MEI_ME anyway. INTEL_MEI_ME selects INTEL_MEI in this file and it was taken as example. What is wrong with select? Why to avoid it use? -- Thanks, Sasha > > thanks, > > greg k-h
