On Wed, Jan 19, 2022 at 11:09:47AM -0800, Navare, Manasi wrote: > On Wed, Jan 19, 2022 at 05:17:05PM +0200, Jani Nikula wrote: > > On Wed, 19 Jan 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > > > it. > > > > > > The one thing that tgl_ddi_pre_enable_dp() is missing that we > > > need is intel_ddi_config_transcoder_dp2(). So we'll bring that > > > over. > > > > > > tgl_ddi_pre_enable_dp() does also have a few things that > > > dg2_ddi_pre_enable_dp() didn't have: > > > - icl_program_mg_dp_mode() -> nop due to intel_phy_is_tc()==false on DG2 > > > - intel_ddi_power_up_lanes() -> nop due to intel_phy_is_combo()==false on DG2 > > > - intel_ddi_mso_configure() -> only matters for MSO panels > > > > > > Another slight difference is that dg2_ddi_pre_enable_dp() was > > > missing a bigjoiner check around intel_dsc_enable(), which > > > tgl_ddi_pre_enable_dp() does have. > > Thanks Ville for this patch, I was just comparing differences between dg2_pre_enable_dp and tgl_pre_enable_dp > in regards to a bug and there is totally no need for two functions with the checks you have here. > > For the bigjoiner check aroind intel_dsc_enable(), I think the function intel_dsc_dp_pps_write(encoder, crtc_state); > also needs to be moved into that check. > And then this functions needs to be called from icl_ddi_bigjoiner_pre_enable() where we call intel_dsc_enable The video DIP lives in the transcoder so we don't want to write it twice. -- Ville Syrjälä Intel
