On Fri, 07 Jan 2022, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > Let's start breaking up and cleaning up the massive i915_reg.h file. > We'll start by moving all registers that are defined in relation to an > engine base to their own header. > > There are probably a bunch of other "engine registers" that we haven't > moved yet (especially those that belong to the render engine in the > 0x2??? range), but this is a relatively straightforward first step. > > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/gen2_engine_cs.c | 1 + > drivers/gpu/drm/i915/gt/gen6_engine_cs.c | 1 + > drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 + > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + > drivers/gpu/drm/i915/gt/intel_engine_regs.h | 197 +++++++++++++ > .../drm/i915/gt/intel_execlists_submission.c | 1 + > drivers/gpu/drm/i915/gt/intel_gt.c | 1 + > drivers/gpu/drm/i915/gt/intel_lrc.c | 1 + > drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 15 - > drivers/gpu/drm/i915/gt/intel_rc6.c | 1 + > drivers/gpu/drm/i915/gt/intel_reset.c | 1 + > drivers/gpu/drm/i915/gt/intel_ring.c | 1 + > .../gpu/drm/i915/gt/intel_ring_submission.c | 1 + > drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 + > drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 1 + > drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 1 + > drivers/gpu/drm/i915/gt/selftest_rps.c | 1 + > drivers/gpu/drm/i915/gt/selftest_timeline.c | 1 + > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 1 + > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 3 +- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 + > drivers/gpu/drm/i915/gvt/mmio_context.c | 1 + > drivers/gpu/drm/i915/gvt/mmio_context.h | 1 + > drivers/gpu/drm/i915/i915_cmd_parser.c | 1 + > drivers/gpu/drm/i915/i915_gpu_error.c | 1 + > drivers/gpu/drm/i915/i915_perf.c | 1 + > drivers/gpu/drm/i915/i915_pmu.c | 1 + > drivers/gpu/drm/i915/i915_reg.h | 267 +----------------- > drivers/gpu/drm/i915/i915_reg_defs.h | 98 +++++++ I think I would've liked to see this file split up as a separate prep patch. BR, Jani. > drivers/gpu/drm/i915/i915_request.c | 1 + > drivers/gpu/drm/i915/intel_pm.c | 1 + > drivers/gpu/drm/i915/intel_uncore.c | 2 +- > 32 files changed, 327 insertions(+), 281 deletions(-) > create mode 100644 drivers/gpu/drm/i915/gt/intel_engine_regs.h > create mode 100644 drivers/gpu/drm/i915/i915_reg_defs.h > -- Jani Nikula, Intel Open Source Graphics Center
