On Wed, 05 Jan 2022, Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote: > Fix the following coccicheck warning: > ./drivers/gpu/drm/i915/display/intel_fbc.c:1757:0-23: WARNING: > intel_fbc_debugfs_false_color_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c > index 160fd2bdafe5..a43f5b74d6ac 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbc.c > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c > @@ -1754,7 +1754,7 @@ static int intel_fbc_debugfs_false_color_set(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(intel_fbc_debugfs_false_color_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(intel_fbc_debugfs_false_color_fops, > intel_fbc_debugfs_false_color_get, > intel_fbc_debugfs_false_color_set, > "%llu\n"); Please fix the indentation on the continuation lines. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
