Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove circ_buf.h includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 16 Dec 2021, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> == Series Details ==
>
> Series: drm/i915: remove circ_buf.h includes
> URL   : https://patchwork.freedesktop.org/series/98130/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> 24a5cb6b532c drm/i915: remove circ_buf.h includes
> -:44: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jiri Slaby <jirislaby@xxxxxxxxxx>' != 'Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>'
>
> total: 0 errors, 1 warnings, 0 checks, 14 lines checked

Now, this is interesting. The patch email has no mention of
jirislaby@xxxxxxxxxx.

However, .mailmap in kernel source root has line:

Jiri Slaby <jirislaby@xxxxxxxxxx> <jslaby@xxxxxxx>

indicating that you prefer jirislaby@xxxxxxxxxx. When I apply the patch,
git am looks that up, and sets:

Author: Jiri Slaby <jirislaby@xxxxxxxxxx>

With that, we end up with an Author/Signed-off-by mismatch.

If you prefer Jiri Slaby <jirislaby@xxxxxxxxxx>, I think you should have
that in git config too.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux