Re: [RFC 4/7] drm/i915/guc: Add GuC's error state capture output structures.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the conditional Rvb - will get that fixed on next rev.

On Tue, 2021-12-07 at 13:01 -0800, Matthew Brost wrote:
> On Mon, Nov 22, 2021 at 03:03:59PM -0800, Alan Previn wrote:
> > 
> >  
> > +struct intel_guc_capture_out_data_header {
> > +	u32 reserved1;
> > +	u32 info;
> > +		#define GUC_CAPTURE_DATAHDR_SRC_TYPE GENMASK(3, 0) /* as per enum guc_capture_type */
> > +		#define GUC_CAPTURE_DATAHDR_SRC_CLASS GENMASK(7, 4) /* as per GUC_MAX_ENGINE_CLASSES */
> > +		#define GUC_CAPTURE_DATAHDR_SRC_INSTANCE GENMASK(11, 8)
> > +	u32 lrca; /* if type-instance, LRCA (address) that hung, else set to ~0 */
> > +	u32 guc_ctx_id; /* if type-instance, context index of hung context, else set to ~0 */
> 
> s/guc_ctx_id/guc_id
> 
> With __packed (per Jani's feedback) as well:
> 
> Reviewed-by: Matthew Brost <matthew.brost@xxxxxxxxx>
> 




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux