> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Sent: Thursday, December 2, 2021 4:43 PM > To: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Yashashvi, Shantam > <shantam.yashashvi@xxxxxxxxx> > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width > > On Thu, Dec 02, 2021 at 11:10:37AM +0000, Srinivas, Vidya wrote: > > > > > > > -----Original Message----- > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > Sent: Thursday, December 2, 2021 4:26 PM > > > To: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx> > > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Yashashvi, Shantam > > > <shantam.yashashvi@xxxxxxxxx> > > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in > > > max_width > > > > > > On Thu, Dec 02, 2021 at 03:25:34AM +0000, Srinivas, Vidya wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > Sent: Wednesday, December 1, 2021 8:33 PM > > > > > To: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx> > > > > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Yashashvi, Shantam > > > > > <shantam.yashashvi@xxxxxxxxx> > > > > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in > > > > > max_width > > > > > > > > > > On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote: > > > > > > PLANE_CUS_CTL has a restriction of 4096 width even though > > > > > > PLANE_SIZE and scaler size registers supports max 5120. > > > > > > Take care of this restriction in max_width. > > > > > > > > > > > > Without this patch, when 5k content is sent on HDR plane with > > > > > > NV12 content, FIFO underrun is seen and screen blanks out. > > > > > > > > > > > > v2: Addressed review comments from Ville. Added separate > > > > > > functions for max_width - for HDR and SDR > > > > > > > > > > > > v3: Addressed review comments from Ville. Changed names of HDR > > > > > > and > > > > > SDR > > > > > > max_width functions to icl_hdr_plane_max_width and > > > > > > icl_sdr_plane_max_width > > > > > > > > > > > > v4: Fixed paranthesis alignment. No code change > > > > > > > > > > > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@xxxxxxxxx> > > > > > > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@xxxxxxxxx> > > > > > > > > > > Hmm. What's this extra sob doing here? > > > > > > > > Hello Ville, sincere apologies. When I run checkpatch.pl I see no > > > > warnings > > > on my host. > > > > However patchwork keeps reporting paranthesis alignment warning. > > > > I tried to push it multiple times after running checkpatch.pl on my host. > > > Really sorry about that. > > > > > > I was asking about the extra "signed-off-by" (sob). > > > > Hello Ville, I am really sorry about that. Should I keep single > > signed-off-by and push the patch again? Kindly let me know. Thank you. > > Yeah, please resend with proper signed-off-by. Hello Ville, I have kept a single signed-off-by and pushed https://patchwork.freedesktop.org/patch/465010/?series=97053&rev=9 Apologies for bothering you. Thank you very much. Kindly have a check. Regards Vidya > > -- > Ville Syrjälä > Intel
