On Wed, 24 Nov 2021, "Lisovskiy, Stanislav" <stanislav.lisovskiy@xxxxxxxxx> wrote: > On Wed, Nov 24, 2021 at 12:23:08PM +0200, Jani Nikula wrote: >> On Thu, 18 Nov 2021, Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx> wrote: >> > +static bool icl_need_wm1_wa(struct drm_i915_private *i915, >> > + enum plane_id plane_id) >> >> Commit subject having "WM0 cursor WA" and the function saying "wm1_wa" >> looks like a discrepancy to the casual reader. > > Agree, not the best naming. Should be either WM0 or WM1. > Thing is that due to nature of that W/A both can be correct. > Patch has been pushed week ago, after r-b from Ville. > > I will send a fix anyway. *shrug* Not sure it matters, just an observation going through mails. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
