On Mon, 22 Nov 2021, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 11/22/21 12:15, Jani Nikula wrote: >> Follow the convention of corresponding .h for .c. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > This series looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > For the series. Thanks for the reviews, pushed to drm-intel-next. BR, Jani. > > Regards, > > Hans > >> --- >> drivers/gpu/drm/i915/display/icl_dsi.c | 1 + >> drivers/gpu/drm/i915/display/intel_dsi.h | 9 -------- >> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 1 + >> drivers/gpu/drm/i915/display/intel_dsi_vbt.h | 22 ++++++++++++++++++++ >> drivers/gpu/drm/i915/display/vlv_dsi.c | 1 + >> 5 files changed, 25 insertions(+), 9 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/display/intel_dsi_vbt.h >> >> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c >> index edc38fbd2545..2f15b322d78f 100644 >> --- a/drivers/gpu/drm/i915/display/icl_dsi.c >> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c >> @@ -36,6 +36,7 @@ >> #include "intel_ddi.h" >> #include "intel_de.h" >> #include "intel_dsi.h" >> +#include "intel_dsi_vbt.h" >> #include "intel_panel.h" >> #include "intel_vdsc.h" >> #include "skl_scaler.h" >> diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h >> index fbc40ffdc02e..e3571ca7db5c 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dsi.h >> +++ b/drivers/gpu/drm/i915/display/intel_dsi.h >> @@ -210,13 +210,4 @@ void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port); >> void assert_dsi_pll_enabled(struct drm_i915_private *i915); >> void assert_dsi_pll_disabled(struct drm_i915_private *i915); >> >> -/* intel_dsi_vbt.c */ >> -bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); >> -void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); >> -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); >> -void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, >> - enum mipi_seq seq_id); >> -void intel_dsi_msleep(struct intel_dsi *intel_dsi, int msec); >> -void intel_dsi_log_params(struct intel_dsi *intel_dsi); >> - >> #endif /* _INTEL_DSI_H */ >> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> index f241bedb8597..c29a13619224 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> @@ -41,6 +41,7 @@ >> #include "i915_drv.h" >> #include "intel_display_types.h" >> #include "intel_dsi.h" >> +#include "intel_dsi_vbt.h" >> #include "vlv_sideband.h" >> >> #define MIPI_TRANSFER_MODE_SHIFT 0 >> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h >> new file mode 100644 >> index 000000000000..dc642c1fe7ef >> --- /dev/null >> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h >> @@ -0,0 +1,22 @@ >> +/* SPDX-License-Identifier: MIT */ >> +/* >> + * Copyright © 2021 Intel Corporation >> + */ >> + >> +#ifndef __INTEL_DSI_VBT_H__ >> +#define __INTEL_DSI_VBT_H__ >> + >> +#include <linux/types.h> >> + >> +enum mipi_seq; >> +struct intel_dsi; >> + >> +bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); >> +void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); >> +void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); >> +void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, >> + enum mipi_seq seq_id); >> +void intel_dsi_msleep(struct intel_dsi *intel_dsi, int msec); >> +void intel_dsi_log_params(struct intel_dsi *intel_dsi); >> + >> +#endif /* __INTEL_DSI_VBT_H__ */ >> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c >> index 59ebfbd46e6f..be070a1afcd0 100644 >> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c >> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c >> @@ -38,6 +38,7 @@ >> #include "intel_de.h" >> #include "intel_display_types.h" >> #include "intel_dsi.h" >> +#include "intel_dsi_vbt.h" >> #include "intel_fifo_underrun.h" >> #include "intel_panel.h" >> #include "skl_scaler.h" >> > -- Jani Nikula, Intel Open Source Graphics Center
