On Tue, May 28, 2013 at 04:00:18PM +0200, Daniel Vetter wrote: > Only lvds/tv did actually check for cloning or not, but many more > places should. > > Notices because my ivb tried to enable both cpu edp and vga on the > first crtc - the resulting confusion between has_pch_encoder, > has_dp_encoder but not actually being a pch dp encoder resulting in > hilarity (hitting a BUG). > > We _really_ need an igt to random-walk our modeset space more > exhaustively. > > I haven't figured out yet why exactly we see this configuration > request from the setcrtc ioctl, but I can reliably reproduce it by > unplugging a bunch of connectors and restarting X. > > Strangely restarting X again fixes things ... > > Cc: Chris Wilson <chris at chris-wilson.co.uk> > Cc: stable at vger.kernel.org > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > --- > - if (intel_encoder_check_is_cloned(&lvds_encoder->base)) > - return false; > - Ok, silly question: If you are removing the callers, why not remove the function as well? Otherwise, the testing for requesting multiple uncloneable encoders on a CRTC looks sane. So finish the job and take my r-b. -Chris -- Chris Wilson, Intel Open Source Technology Centre
