✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/6] drm/i915/audio: group audio under anonymous struct in drm_i915_private

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: series starting with [v3,1/6] drm/i915/audio: group audio under anonymous struct in drm_i915_private
URL   : https://patchwork.freedesktop.org/series/96578/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
eaff73f1c59d drm/i915/audio: group audio under anonymous struct in drm_i915_private
b71eaad880d2 drm/i915/audio: name the audio sub-struct in drm_i915_private
-:325: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio.lpe.platdev"
#325: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1408:
+	if ((dev_priv)->audio.lpe.platdev != NULL)

-:338: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio.lpe.platdev"
#338: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:77:
+#define HAS_LPE_AUDIO(dev_priv) ((dev_priv)->audio.lpe.platdev != NULL)

-:347: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#347: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:99:
+	rsc[0].start    = rsc[0].end = dev_priv->audio.lpe.irq;

total: 0 errors, 0 warnings, 3 checks, 441 lines checked
ba85b7efe4cf drm/i915/audio: define the audio struct separately from drm_i915_private
81199ff96aa3 drm/i915/audio: move intel_audio_funcs internal to intel_audio.c
86620a390924 drm/i915/audio: clean up LPE audio init/cleanup calls
3d26d2e9512b drm/i915/audio: rename intel_init_audio_hooks to intel_audio_hooks_init





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux