On Tue, 21 May 2013 21:54:57 +0200
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> - if (clock < 200000) {
> + if (crtc->config.port_clock == 162000) {
> /* For a long time we've carried around a ILK-DevA w/a for the
> * 160MHz clock. If we're really unlucky, it's still required.
> */
> DRM_DEBUG_KMS("160MHz cpu eDP clock, might need ilk devA w/a\n");
> dpa_ctl |= DP_PLL_FREQ_160MHZ;
> + intel_dp->DP |= DP_PLL_FREQ_160MHZ;
> } else {
> dpa_ctl |= DP_PLL_FREQ_270MHZ;
> + intel_dp->DP |= DP_PLL_FREQ_270MHZ;
> }
Nitpick, this seems like unrelated code motion? It's probably more
sensible to do it here though, so no objection.
I'm sure I missed something on a GM45 DP docked config or a VLV
all-in-one with DP->LVDS bridge, but overall it looks ok.
Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
