Re: [PATCH 0/7] drm/i915/adlp/fb: Remove CCS FB stride restrictions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I didn't notice anything nag worthy, entire set look ok to me.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx>

On 27.10.2021 1.50, Imre Deak wrote:
This patchset removes the CCS FB stride restrictions on ADLP. This makes
the uAPI for these FBs (via CCS modifiers) match the TGL one.

It also fixes a few issues I noticed during testing.

I tested the patchset along with [1] (required due to the ADLP uAPI
change) on SKL/TGL/ADLP.

[1] https://patchwork.freedesktop.org/series/96316/

Test-with: 20211026212620.2718277-1-imre.deak@xxxxxxxxx

Cc: Nanley G Chery <nanley.g.chery@xxxxxxxxx>
Cc: Sameer Lattannavar <sameer.lattannavar@xxxxxxxxx>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx>
Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Imre Deak (7):
   drm/i915/fb: Fix rounding error in subsampled plane size calculation
   drm/i915/adlp/fb: Prevent the mapping of redundant trailing padding
     NULL pages
   drm/i915/fb: Factor out functions to remap contiguous FB obj pages
   drm/i915/adlp/fb: Fix remapping of linear CCS AUX surfaces
   drm/i915/fb: Rename i915_color_plane_view::stride to mapping_stride
   drm/i915/adlp/fb: Remove restriction on semiplanar UV plane offset
   drm/i915/adlp/fb: Remove restriction on CCS AUX plane strides

  drivers/gpu/drm/i915/display/i9xx_plane.c     |   4 +-
  drivers/gpu/drm/i915/display/intel_cursor.c   |   6 +-
  drivers/gpu/drm/i915/display/intel_display.c  |  19 +-
  .../drm/i915/display/intel_display_types.h    |   3 +-
  drivers/gpu/drm/i915/display/intel_fb.c       | 196 +++++++------
  drivers/gpu/drm/i915/display/intel_fbc.c      |   2 +-
  drivers/gpu/drm/i915/display/intel_sprite.c   |   8 +-
  .../drm/i915/display/skl_universal_plane.c    |   4 +-
  drivers/gpu/drm/i915/gt/intel_ggtt.c          | 272 +++++++++++-------
  drivers/gpu/drm/i915/i915_vma_types.h         |  19 +-
  10 files changed, 324 insertions(+), 209 deletions(-)





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux