On Fri, May 24, 2013 at 06:13:15PM +0200, Daniel Vetter wrote: > On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > > pfit_size stores the request mode, which matches crtc->config.requested > > mode. Instead of jumping through hoops I think I'd be better to directly > > use those values ... > > Scrap that, I can't read code ;-) One change I'd like is to store the pfit window w/h as individual values instead of sticking the raw register value into pipe_config. Nothing else seems to be stored there in raw form, so it feels inconsistent. And it would avoid the mask/shift busniness when extracting the values. -- Ville Syrj?l? Intel OTC