On Fri, Oct 22, 2021 at 07:27:57PM +0300, Jani Nikula wrote:
> Add a standalone definition of struct intel_audio_private, and note that
> all of it is private to intel_audio.c.
>
> Cc: Dave Airlie <airlied@xxxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 45 ++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 9c77610acf23..ed86633a587b 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -828,6 +828,29 @@ struct i915_selftest_stash {
> struct ida mock_region_instances;
> };
>
> +/* intel_audio.c private */
> +struct intel_audio_private {
Not sure the "_private" is actually useful. I'd just call it
intel_audio. The fact that struct drm_i915_private
already says "private" doesn't mean anything to anyone anyway.
--
Ville Syrjälä
Intel
