Re: ✗ Fi.CI.IGT: failure for series starting with [01/28] drm/i915: Fix i915_request fence wait semantics

[Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>]

Op 22-10-2021 om 13:24 schreef Matthew Auld:

On Thu, 21 Oct 2021 at 13:57, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote:

Patch Details

Series:	series starting with [01/28] drm/i915: Fix i915_request fence wait semantics
URL:	https://patchwork.freedesktop.org/series/96115/
State:	failure
Details:	https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21402/index.html

CI Bug Log - changes from CI_DRM_10768_full -> Patchwork_21402_full

Summary

FAILURE

Serious unknown changes coming with Patchwork_21402_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21402_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_21402_full:

IGT changes

Possible regressions

• igt@gem_linear_blits@normal:

  • shard-glk: PASS -> FAIL

• igt@gem_mmap_gtt@cpuset-big-copy-xy:

  • shard-iclb: NOTRUN -> INCOMPLETE

• igt@gem_ppgtt@blt-vs-render-ctxn:

  • shard-tglb: PASS -> FAIL +1 similar issue

Maarten, do you know if these failures are related to this series? Perhaps the last one?

Yeah, unfortunately they are. In general, I think the last patch is fine, but we hit more ENOSPC errors because of the extra locking requirements around eviction.

Most of these issues don't happen when we remove the pinning in execbuf, but already earlier in the series, usuallly with locking in eviction paths.

I added some fixes in case it affects the object we are currently trying to pin, like calling i915_gem_evict_vm() in vm_fault_gtt that already fix a lot of issues, but each remaining ENOSPC error like the 3 above requires separate debugging to resolve. I've fixed many cases already, it seems those are remaining.

The fix for gem_mmap_gtt by calling i915_gem_evict_vm() to evict the current object seems to be insufficient on ICL, but originally other platforms were hit harder by this problem, and there it works as intended. :)

Just a few edge cases remaining, fortunately. The majority of tests now pass.

 

Known issues

Here are the changes found in Patchwork_21402_full that come from known issues:

IGT changes

Issues hit

• igt@feature_discovery@display-2x:

  • shard-tglb: NOTRUN -> SKIP ([i915#1839])

• igt@gem_create@create-massive:

  • shard-snb: NOTRUN -> DMESG-WARN ([i915#3002])

• igt@gem_ctx_isolation@preservation-s3@rcs0:

  • shard-tglb: PASS -> INCOMPLETE ([i915#1373])

• igt@gem_ctx_isolation@preservation-s3@vcs0:

  • shard-kbl: PASS -> DMESG-WARN ([i915#180]) +3 similar issues

• igt@gem_ctx_isolation@preservation-s3@vecs0:

  • shard-skl: PASS -> INCOMPLETE ([i915#198])

• igt@gem_ctx_persistence@idempotent:

  • shard-snb: NOTRUN -> SKIP ([fdo#109271] / [i915#1099]) +4 similar issues

• igt@gem_exec_fair@basic-none-solo@rcs0:

  • shard-glk: PASS -> FAIL ([i915#2842])

• igt@gem_exec_fair@basic-pace@bcs0:

  • shard-tglb: PASS -> FAIL ([i915#2842]) +2 similar issues

• igt@gem_exec_fair@basic-pace@vecs0:

  • shard-kbl: PASS -> FAIL ([i915#2842]) +2 similar issues

• igt@gem_exec_params@no-vebox:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109283])

• igt@gem_pwrite@basic-exhaustion:

  • shard-kbl: NOTRUN -> WARN ([i915#2658])

• igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted:

  • shard-tglb: NOTRUN -> SKIP ([i915#4270])

• igt@gem_userptr_blits@readonly-unsync:

  • shard-tglb: NOTRUN -> SKIP ([i915#3297])

• igt@gen7_exec_parse@basic-rejected:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109289]) +2 similar issues

• igt@gen9_exec_parse@cmd-crossing-page:

  • shard-tglb: NOTRUN -> SKIP ([i915#2856]) +2 similar issues

• igt@i915_pm_dc@dc6-psr:

  • shard-iclb: PASS -> FAIL ([i915#454])

• igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:

  • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [i915#1937])

• igt@i915_pm_rpm@dpms-non-lpsp:

  • shard-tglb: NOTRUN -> SKIP ([fdo#111644] / [i915#1397] / [i915#2411])

• igt@i915_pm_rpm@gem-execbuf-stress-pc8:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109506] / [i915#2411])

• igt@i915_suspend@fence-restore-untiled:

  • shard-apl: PASS -> DMESG-WARN ([i915#180]) +1 similar issue

• igt@kms_big_fb@linear-16bpp-rotate-90:

  • shard-tglb: NOTRUN -> SKIP ([fdo#111614]) +1 similar issue

• igt@kms_big_fb@linear-32bpp-rotate-0:

  • shard-glk: PASS -> DMESG-WARN ([i915#118])

• igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:

  • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [i915#3777])

• igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#3777])

• igt@kms_big_fb@yf-tiled-16bpp-rotate-90:

  • shard-tglb: NOTRUN -> SKIP ([fdo#111615]) +2 similar issues

• igt@kms_big_joiner@invalid-modeset:

  • shard-skl: NOTRUN -> SKIP ([fdo#109271]) +19 similar issues

• igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:

  • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [i915#3886]) +1 similar issue

• igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#3886]) +4 similar issues

• igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:

  • shard-skl: NOTRUN -> SKIP ([fdo#109271] / [i915#3886])

• igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs:

  • shard-tglb: NOTRUN -> SKIP ([i915#3689]) +6 similar issues

• igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:

  • shard-tglb: NOTRUN -> SKIP ([i915#3689] / [i915#3886]) +1 similar issue

• igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs:

  • shard-kbl: NOTRUN -> SKIP ([fdo#109271]) +33 similar issues

• igt@kms_chamelium@hdmi-mode-timings:

  • shard-snb: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827]) +13 similar issues

• igt@kms_color@pipe-a-ctm-0-75:

  • shard-skl: PASS -> DMESG-WARN ([i915#1982]) +2 similar issues

• igt@kms_color_chamelium@pipe-a-ctm-green-to-red:

  • shard-skl: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827])

• igt@kms_color_chamelium@pipe-b-ctm-limited-range:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109284] / [fdo#111827]) +5 similar issues

• igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827]) +10 similar issues

• igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:

  • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827]) +1 similar issue

• igt@kms_content_protection@atomic:

  • shard-apl: NOTRUN -> TIMEOUT ([i915#1319])

• igt@kms_content_protection@atomic-dpms:

  • shard-kbl: NOTRUN -> TIMEOUT ([i915#1319])

• igt@kms_content_protection@dp-mst-type-0:

  • shard-tglb: NOTRUN -> SKIP ([i915#3116])

• igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen:

  • shard-tglb: NOTRUN -> SKIP ([i915#3359]) +3 similar issues

• igt@kms_cursor_crc@pipe-d-cursor-512x170-random:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109279] / [i915#3359]) +7 similar issues

• igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:

  • shard-snb: NOTRUN -> SKIP ([fdo#109271]) +281 similar issues

• igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:

  • shard-iclb: NOTRUN -> SKIP ([fdo#109274] / [fdo#109278])

• igt@kms_cursor_legacy@pipe-d-torture-bo:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#533])

• igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:

  • shard-tglb: NOTRUN -> SKIP ([i915#4103])

• igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:

  • shard-tglb: NOTRUN -> SKIP ([i915#3528])

• igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:

  • shard-glk: PASS -> FAIL ([i915#79]) +1 similar issue

• igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:

  • shard-kbl: NOTRUN -> DMESG-WARN ([i915#180]) +1 similar issue

• igt@kms_flip@flip-vs-suspend@a-dp1:

  • shard-apl: NOTRUN -> DMESG-WARN ([i915#180])

• igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:

  • shard-skl: PASS -> FAIL ([i915#2122])

• igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt:

  • shard-tglb: NOTRUN -> SKIP ([fdo#111825]) +26 similar issues

• igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:

  • shard-tglb: PASS -> INCOMPLETE ([i915#2828] / [i915#456])

• igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:

  • shard-skl: NOTRUN -> FAIL ([fdo#108145] / [i915#265])

• igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:

  • shard-apl: NOTRUN -> FAIL ([i915#265])

• igt@kms_plane_alpha_blend@pipe-c-alpha-basic:

  • shard-kbl: NOTRUN -> FAIL ([fdo#108145] / [i915#265]) +1 similar issue

• igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:

  • shard-skl: PASS -> FAIL ([fdo#108145] / [i915#265]) +1 similar issue

• igt@kms_plane_lowres@pipe-b-tiling-y:

  • shard-tglb: NOTRUN -> SKIP ([i915#3536])

• igt@kms_plane_lowres@pipe-d-tiling-yf:

  • shard-tglb: NOTRUN -> SKIP ([fdo#112054]) +1 similar issue

• igt@kms_psr2_sf@plane-move-sf-dmg-area-1:

  • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [i915#658]) +1 similar issue

• igt@kms_psr2_sf@plane-move-sf-dmg-area-2:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#658]) +3 similar issues

• igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:

  • shard-tglb: NOTRUN -> SKIP ([i915#2920]) +2 similar issues

• igt@kms_psr2_su@page_flip:

  • shard-tglb: NOTRUN -> SKIP ([i915#1911])

• igt@kms_psr@psr2_suspend:

  • shard-iclb: PASS -> SKIP ([fdo#109441])

  • shard-tglb: NOTRUN -> FAIL ([i915#132] / [i915#3467])

• igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:

  • shard-skl: PASS -> INCOMPLETE ([i915#198] / [i915#2828])

• igt@kms_vblank@pipe-d-ts-continuation-idle:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271]) +93 similar issues

• igt@nouveau_crc@pipe-a-ctx-flip-detection:

  • shard-tglb: NOTRUN -> SKIP ([i915#2530]) +2 similar issues

• igt@perf_pmu@event-wait@rcs0:

  • shard-tglb: NOTRUN -> SKIP ([fdo#112283])

• igt@prime_nv_pcopy@test3_5:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109291])

• igt@prime_vgem@fence-write-hang:

  • shard-tglb: NOTRUN -> SKIP ([fdo#109295])

• igt@sysfs_clients@create:

  • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#2994]) +1 similar issue

• igt@sysfs_clients@fair-0:

  • shard-tglb: NOTRUN -> SKIP ([i915#2994])

• igt@sysfs_clients@sema-10:

  • shard-skl: NOTRUN -> SKIP ([fdo#109271] / [i915#2994])

Possible fixes

• igt@drm_mm@all@evict:

  • shard-skl: INCOMPLETE ([i915#198]) -> PASS

• igt@gem_exec_fair@basic-none@vecs0:

  • shard-kbl: FAIL ([i915#2842]) -> PASS

• igt@gem_exec_fair@basic-pace@bcs0:

  • shard-iclb: FAIL ([i915#2842]) -> PASS

• igt@gem_exec_fair@basic-pace@vcs1:

  • shard-tglb: FAIL ([i915#2842]) -> PASS

• igt@gem_softpin@noreloc-s3:

  • shard-apl: DMESG-WARN ([i915#180]) -> PASS

• igt@i915_pm_dc@dc6-dpms:

  • shard-iclb: FAIL ([i915#454]) -> PASS

• igt@i915_suspend@forcewake:

  • shard-skl: INCOMPLETE ([i915#636]) -> PASS

• igt@kms_color@pipe-b-ctm-0-75:

  • shard-skl: DMESG-WARN ([i915#1982]) -> PASS

• igt@kms_cursor_crc@pipe-a-cursor-suspend:

  • shard-tglb: INCOMPLETE ([i915#2828] / [i915#456]) -> PASS

• igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1:

  • shard-kbl: FAIL ([i915#79]) -> PASS

• igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:

  • shard-iclb: SKIP ([i915#3701]) -> PASS

• igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:

  • shard-skl: FAIL ([fdo#108145] / [i915#265]) -> PASS

• igt@kms_psr@psr2_cursor_plane_move:

  • shard-iclb: SKIP ([fdo#109441]) -> PASS

• igt@kms_vblank@pipe-a-ts-continuation-suspend:

  • shard-tglb: INCOMPLETE ([i915#456]) -> PASS +1 similar issue

Warnings

• igt@i915_pm_rc6_residency@rc6-fence:

  • shard-iclb: WARN ([i915#2684]) -> WARN ([i915#1804] / [i915#2684])

• igt@kms_psr2_sf@plane-move-sf-dmg-area-0:

  • shard-iclb: SKIP ([i915#658]) -> SKIP ([i915#2920])

• igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:

  • shard-iclb: SKIP ([i915#2920]) -> SKIP ([i915#658]) +2 similar issues

• igt@kms_psr2_su@page_flip:

  • shard-iclb: FAIL ([i915#4148]) -> SKIP ([fdo#109642] / [fdo#111068] / [i915#658])

• igt@runner@aborted:

  • shard-kbl: (FAIL, FAIL) ([i915#3002] / [i915#3363] / [i915#4312]) -> (FAIL, FAIL, FAIL) ([i915#1436] / [i915#180] / [i915#3002] / [i915#3363] / [i915#4312])

  • shard-apl: (FAIL, FAIL, [FAIL][140]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#4312]) -> ([FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([i915#180] / [i915#3002] / [i915#3363] / [i915#4312])