On Thu, Oct 21, 2021 at 02:32:13PM -0700, Lucas De Marchi wrote: > On Thu, Oct 21, 2021 at 10:05:40PM +0300, Ville Syrjälä wrote: > >On Thu, Oct 21, 2021 at 11:18:47AM -0700, Lucas De Marchi wrote: > >> We left the definition IS_CANNONLAKE() macro while removing it from the > >> tree due to having to merge the changes in different branches. Now that > >> everything is back in sync and nobody is using IS_CANNONLAKE(), we can > >> safely ditch it. > >> > >> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > > >Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > >I found another leftover somewhere else, but now I forgot where > >it was. I guess it'll come back to me eventually. > > drivers/gpu/drm/i915/intel_pch.c, which I suspect is what you're talking > about due to your recent patches. But that one is correct as we still > have Cannon Lake Point (and I never remember if P in CNP is for PCH or > Point) > > there is another one in a comment in drivers/gpu/drm/i915/gt/intel_gt.c, > too. Sleeping on it helped, I now remember that it's the SAGV block time. -- Ville Syrjälä Intel
