On Wed, 22 May 2013 15:36:17 +0300 Jani Nikula <jani.nikula at intel.com> wrote: > Both the intel_dpio_{read,write} and valleyview_{punit,nc}_{read,write} > use the IOSF sideband interface. They access the same registers and do > mostly the same stuff, but no shared code. There are even duplicate > register defines for the same registers. Both have locking, but the > former use dpio_lock and the latter rps.hw_lock. It's racy. Nice catch... The docs for each came from different places with no indication that the req register was re-used, but it's obvious now of course. Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org>