On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Move the lpt_get_iclkip() call from hsw_crt_get_config() > since that's where we have the lpt_program_iclkip() call > as well. > > Tehcnically this isn't perhaps quite right since iCLKIP > is providing the CRT dotclock. So one can argue all of > it should be directly in intel_crt.c. But since the CRT > port is the only one on the PCH sticking it all into the > PCH code seems OK. Looks good, Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>
