On Wed, Oct 13, 2021 at 11:40:11PM +0300, Ville Syrjälä wrote: > On Fri, Oct 08, 2021 at 03:19:08AM +0300, Imre Deak wrote: > > bool is_ccs_plane(const struct drm_framebuffer *fb, int plane); > > bool is_gen12_ccs_plane(const struct drm_framebuffer *fb, int plane); > > bool is_gen12_ccs_cc_plane(const struct drm_framebuffer *fb, int plane); > > Side note: > We have quite a few of these 'int plane' things still around. I'd > like to see them all renamed to 'color_plane' so that we don't get > confused between diffrent kinds of planes. > > The rules that I've been going for everywhere: > - int color_plane == plane of a planar/compressed framebuffer > - struct intel_plane *plane == representation of the piece of > hardware that does the scanout > - enum plane plane_id == standalone version of plane->id > - enum i9xx_plane_id i9xx_plane == standalone version of plane->i9xx_plane Ok, makes sense, I'll s/plane/color_plane/ in functions I added in this patchset and will follow up to convert the remaining ones. > -- > Ville Syrjälä > Intel
