On Wed, Oct 13, 2021 at 01:11:58PM +0300, Jani Nikula wrote: > Three main ideas here: > > - vlv sideband only has the name "sideband" in common with the rest of > intel_sideband.[ch] I wouldn't put it like that. There are two actual sideband implementtions in that file: - vlv/chv iosf sideband (vlv_sideband) - lpt/wpt iosf sideband (intel_sbi) And the third thing in that file is the snb+ pcode mailbox stuff, which has nothing to do with sideband. -- Ville Syrjälä Intel