On Thu, May 16, 2013 at 02:40:35PM +0300, Imre Deak wrote: > On ValleyView for both eDP and DP the AUX input clock is 200MHz, so we > can calculate for both the clock divider for the 2MHz target rate at the > same place. Afterwards we can also replace the is_cpu_edp() check with a > check for port A. > > Signed-off-by: Imre Deak <imre.deak at intel.com> There's a now-dead IS_VLV case in intel_hrawclk which should be killed with this patch, too. -Daniel > --- > drivers/gpu/drm/i915/intel_dp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 90ae58a..b99da13 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -317,11 +317,11 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, > * Note that PCH attached eDP panels should use a 125MHz input > * clock divider. > */ > - if (is_cpu_edp(intel_dp)) { > + if (IS_VALLEYVIEW(dev)) { > + aux_clock_divider = 100; > + } else if (intel_dig_port->port == PORT_A) { > if (HAS_DDI(dev)) > aux_clock_divider = intel_ddi_get_cdclk_freq(dev_priv) >> 1; > - else if (IS_VALLEYVIEW(dev)) > - aux_clock_divider = 100; > else if (IS_GEN6(dev) || IS_GEN7(dev)) > aux_clock_divider = 200; /* SNB & IVB eDP input clock at 400Mhz */ > else > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch