Hi Sujaritha, On Fri, Oct 08, 2021 at 01:44:54PM -0700, Sujaritha Sundaresan wrote: > This patch adds the following new sysfs frequency attributes; > - punit_req_freq_mhz > - throttle_reason_status > - throttle_reason_pl1 > - throttle_reason_pl2 > - throttle_reason_pl4 > - throttle_reason_thermal > - throttle_reason_prochot > - throttle_reason_ratl > - throttle_reason_vr_thermalert > - throttle_reason_vr_tdc > > Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@xxxxxxxxx> > Cc: Dale B Stimson <dale.b.stimson@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/intel_rps.c | 83 +++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_rps.h | 10 +++ > drivers/gpu/drm/i915/i915_reg.h | 11 +++ > drivers/gpu/drm/i915/i915_sysfs.c | 135 ++++++++++++++++++++++++++++ if we add these here we're stuck forever! Can this hold a few days? The rest of the patch looks OK to me. Andi