== Series Details == Series: series starting with [v4,1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached() URL : https://patchwork.freedesktop.org/series/95564/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9a49a4f47f72 drm/i915/dp: abstract intel_dp_lane_max_vswing_reached() 74e50adbec7f drm/i915/dg2: update link training for 128b/132b -:54: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #54: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1349: + return train_set & DP_TX_FFE_PRESET_VALUE_MASK; + } else { -:86: CHECK:LINE_SPACING: Please don't use multiple blank lines #86: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:307: + -:143: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #143: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:396: +#define TRAIN_REQ_TX_FFE_ARGS(link_status) \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 0), \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 1), \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 2), \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 3) -:143: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'link_status' - possible side-effects? #143: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:396: +#define TRAIN_REQ_TX_FFE_ARGS(link_status) \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 0), \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 1), \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 2), \ + _TRAIN_REQ_TX_FFE_ARGS(link_status, 3) -:189: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #189: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:521: +#define TRAIN_SET_TX_FFE_ARGS(train_set) \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[0]), \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[1]), \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[2]), \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[3]) -:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'train_set' - possible side-effects? #189: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:521: +#define TRAIN_SET_TX_FFE_ARGS(train_set) \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[0]), \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[1]), \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[2]), \ + _TRAIN_SET_TX_FFE_ARGS((train_set)[3]) total: 2 errors, 1 warnings, 3 checks, 251 lines checked
