On Thu, 07 Oct 2021, Dave Airlie <airlied@xxxxxxxxx> wrote: > This is another series in the refactor intel_display.c into more manageable > places. > > This moves the initial plane config and all the fb pin/unpin code out. > > It also refactors both a little to make the interfaces cleaner. I had a few nitpicks I commented on. Overall this looks good to me, but I'd like Ville's input on the code movement at the high level, are the split and files sane etc. I can do the detailed review after that. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center