> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Dave Airlie > Sent: maanantai 4. lokakuuta 2021 3.33 > To: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: Nikula, Jani <jani.nikula@xxxxxxxxx>; Intel Graphics Development <intel- > gfx@xxxxxxxxxxxxxxxxxxxxx>; Dave Airlie <airlied@xxxxxxxxxx>; Sarvela, Tomi P > <tomi.p.sarvela@xxxxxxxxx> > Subject: Re: [PATCH 01/24] drm/i915/uncore: split the fw get function > into separate vfunc > > On Sun, 3 Oct 2021 at 05:27, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > > > On Wed, Sep 29, 2021 at 01:57:45AM +0300, Jani Nikula wrote: > > > From: Dave Airlie <airlied@xxxxxxxxxx> > > > > > > constify it while here. drop the put function since it was never > > > overloaded and always has done the same thing, no point in > > > indirecting it for show. > > > > > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx> > > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > > > This has totally broken snb and ivb machines. Total death ensues > > somewhere in uncore init after some backtraces fly by. > > Didn't get any logs out to disk unfortunately. Please revert. > > > > Sadly CI is still afraid to report when machines disappear. > > For the bat report you at least get a list of machines that were awol, > > but the shard run seems to not even mention that all snbs suddenly > > vanished. > > > > I've said it before and I'll say it again. We really should > > *not* be loading i915 when the machine boots. That way we'd at least > > get the machine up and running and can report that loading i915 is the > > thing that killed it... > > That is frustrating, I've sent a oneline fix that should fix it up. > hopefully CI will pick it up. It seems it did (this for ivb, snb only): https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21231/index.html?hosts=snb%7Civb > > Dave.
