On Thu, 30 Sep 2021, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> On Thu, Sep 30, 2021 at 02:24:36PM +0300, Jani Nikula wrote:
>> Avoid using the incidental -EPERM.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>> ---
>> drivers/gpu/drm/i915/intel_dram.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
>> index 91866520c173..a506a2196de4 100644
>> --- a/drivers/gpu/drm/i915/intel_dram.c
>> +++ b/drivers/gpu/drm/i915/intel_dram.c
>> @@ -444,7 +444,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)
>> break;
>> default:
>> MISSING_CASE(val & 0xf);
>> - return -1;
>> + return -ENOENT;
>
> Everything else is -EINVAL in that file. So maybe just stick to
> that? I guess for a bunch of these maybe something different
> might make sense to indicate that it's the hw telling us nonsense
> (or the driver is actually missing some necessaty stuff).
> But boesn't really matter since it's just a bogus value.
Exceptionally fixed this while pushing.
>
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Thanks, pushed.
BR,
Jani.
>
>> }
>> } else {
>> switch (val & 0xf) {
>> @@ -462,7 +462,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)
>> break;
>> default:
>> MISSING_CASE(val & 0xf);
>> - return -1;
>> + return -ENOENT;
>> }
>> }
>>
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
