== Series Details == Series: i915/display: split and constify vtable (rev7) URL : https://patchwork.freedesktop.org/series/94459/ State : warning == Summary == $ dim checkpatch origin/drm-tip 587d41d45da4 drm/i915/uncore: split the fw get function into separate vfunc 2c15ba24ea1a drm/i915/pm: drop get_fifo_size vfunc. 3891d89ead96 drm/i915: make update_wm take a dev_priv. 666a5ee103d4 drm/i915/wm: provide wrappers around watermark vfuncs calls (v2) -:10: WARNING:TYPO_SPELLING: 'existance' may be misspelled - perhaps 'existence'? #10: One thing to note is that the code checks the existance of some ^^^^^^^^^ -:29: CHECK:LINE_SPACING: Please don't use multiple blank lines #29: FILE: drivers/gpu/drm/i915/display/intel_display.c:129: + -:73: WARNING:LINE_SPACING: Missing a blank line after declarations #73: FILE: drivers/gpu/drm/i915/display/intel_display.c:173: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.compute_pipe_wm) -:82: WARNING:LINE_SPACING: Missing a blank line after declarations #82: FILE: drivers/gpu/drm/i915/display/intel_display.c:182: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (!dev_priv->display.compute_intermediate_wm) -:94: WARNING:LINE_SPACING: Missing a blank line after declarations #94: FILE: drivers/gpu/drm/i915/display/intel_display.c:194: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.initial_watermarks) { -:105: WARNING:LINE_SPACING: Missing a blank line after declarations #105: FILE: drivers/gpu/drm/i915/display/intel_display.c:205: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.atomic_update_watermarks) -:113: WARNING:LINE_SPACING: Missing a blank line after declarations #113: FILE: drivers/gpu/drm/i915/display/intel_display.c:213: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.optimize_watermarks) -:120: WARNING:LINE_SPACING: Missing a blank line after declarations #120: FILE: drivers/gpu/drm/i915/display/intel_display.c:220: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.compute_global_watermarks) -:134: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20) #134: FILE: drivers/gpu/drm/i915/display/intel_display.c:2632: + if (!intel_initial_watermarks(state, crtc)) + if (new_crtc_state->update_wm_pre) -:135: WARNING:TABSTOP: Statements should start on a tabstop #135: FILE: drivers/gpu/drm/i915/display/intel_display.c:2633: + if (new_crtc_state->update_wm_pre) -:176: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #176: FILE: drivers/gpu/drm/i915/display/intel_display.c:3676: + if (!intel_initial_watermarks(state, crtc)) + intel_update_watermarks(dev_priv); total: 0 errors, 10 warnings, 1 checks, 319 lines checked d064324410a5 drm/i915: add wrappers around cdclk vtable funcs. -:32: WARNING:LINE_SPACING: Missing a blank line after declarations #32: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:71: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + return dev_priv->display.bw_calc_min_cdclk(state); total: 0 errors, 1 warnings, 0 checks, 127 lines checked 6c34acc82bf4 drm/i915/display: add intel_fdi_link_train wrapper. 9209bf88e3d6 drm/i915: split clock gating init from display vtable c1f5b502c262 drm/i915: split watermark vfuncs from display vtable. 6de505ea22e9 drm/i915: split color functions from display vtable b43ad494fb30 drm/i915: split audio functions from display vtable 02500cc6bc12 drm/i915: split cdclk functions from display vtable. 3856fade357f drm/i915: split irq hotplug function from display vtable 4dd08ab5875f drm/i915: split fdi link training from display vtable. c4b9847c3bef drm/i915: split the dpll clock compute out from display vtable. 8b02fe332309 drm/i915: constify fdi link training vtable cb661e0b73ca drm/i915: constify hotplug function vtable. 2e62bc8a9786 drm/i915: constify color function vtable. -:197: CHECK:BRACES: Unbalanced braces around else statement #197: FILE: drivers/gpu/drm/i915/display/intel_color.c:2194: + } else total: 0 errors, 0 warnings, 1 checks, 187 lines checked 523632d6053b drm/i915: constify the audio function vtable c821ffb519c1 drm/i915: constify the dpll clock vtable 7bf097d0efa6 drm/i915: constify the cdclk vtable ba86233a6aea drm/i915: drop unused function ptr and comments. 66b4fe4263a1 drm/i915: constify display function vtable 92611ae09018 drm/i915: constify clock gating init vtable. 40e25093e553 drm/i915: constify display wm vtable
