On Mon, Sep 13, 2021 at 05:44:34PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Let's not configure the single transcoder's TRANSCONF multiple > times with bigjoiner. No real harm I suppose but since we already > have the bigjoiner if statement directly above might as well suck > this in there and skip the redundant programming. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Yes I agree Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> Manasi > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 2430142b0337..24214e6249a9 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -3059,10 +3059,9 @@ static void hsw_crtc_enable(struct intel_atomic_state *state, > &new_crtc_state->fdi_m_n, NULL); > > hsw_set_frame_start_delay(new_crtc_state); > - } > > - if (!transcoder_is_dsi(cpu_transcoder)) > hsw_set_transconf(new_crtc_state); > + } > > crtc->active = true; > > -- > 2.32.0 >
