On Mon, 20 Sep 2021, "Gupta, Anshuman" <anshuman.gupta@xxxxxxxxx> wrote: >> -----Original Message----- >> From: Nikula, Jani <jani.nikula@xxxxxxxxx> >> Sent: Monday, September 20, 2021 1:12 PM >> To: De Marchi, Lucas <lucas.demarchi@xxxxxxxxx> >> Cc: Auld, Matthew <matthew.auld@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; >> dri-devel@xxxxxxxxxxxxxxxxxxxxx; Gupta, Anshuman >> <anshuman.gupta@xxxxxxxxx> >> Subject: Re: [PATCH 14/19] drm/i915/oprom: Basic sanitization >> >> On Fri, 17 Sep 2021, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote: >> > On Mon, May 17, 2021 at 02:57:33PM +0300, Jani Nikula wrote: >> >>On Mon, 12 Apr 2021, Matthew Auld <matthew.auld@xxxxxxxxx> wrote: >> >>> From: Anshuman Gupta <anshuman.gupta@xxxxxxxxx> >> >>> >> >>> Sanitize OPROM header, CPD signature and OPROM PCI version. >> >>> OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB >> structures and >> >>> PCI struct offsets are provided by GSC counterparts. >> >>> These are yet to be Documented in B.Spec. >> >>> After successful sanitization, extract VBT from opregion image. >> >> >> >>So I don't understand what the point is with two consecutive patches >> >>where the latter rewrites a lot of the former. >> > >> > I actually wonder what's the point of this. Getting it from spi is >> > already the fallback and looks much more complex. Yes, it's pretty >> > detailed and document the format pretty well, but it still looks more >> > complex than the initial code. Do you see additional benefit in this >> > one? > Getting opregion image from spi is needed to get the intel_opregion and its mailboxes on discrete card. I mean what's the point of the "drm/i915/oprom: Basic sanitization" patch? And if that's needed, then why is it separate from "drm/i915/dg1: Read OPROM via SPI controller"? >> The commit message doesn't really explain much. Anshuman? > I will get rework of the patches and float it again. Lucas already sent something, please sync with him. BR, Jani. > Thanks, > Anshuman Gupta. >> >> BR, >> Jani. >> >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center
