== Series Details == Series: i915/display: split and constify vtable (rev5) URL : https://patchwork.freedesktop.org/series/94459/ State : warning == Summary == $ dim checkpatch origin/drm-tip e37b65685b48 drm/i915/uncore: split the fw get function into separate vfunc 870e9ca20427 drm/i915/pm: drop get_fifo_size vfunc. ca9c40d0be2d drm/i915: make update_wm take a dev_priv. dcbf48b5c63a drm/i915/wm: provide wrappers around watermark vfuncs calls (v2) -:10: WARNING:TYPO_SPELLING: 'existance' may be misspelled - perhaps 'existence'? #10: One thing to note is that the code checks the existance of some ^^^^^^^^^ -:29: CHECK:LINE_SPACING: Please don't use multiple blank lines #29: FILE: drivers/gpu/drm/i915/display/intel_display.c:129: + -:73: WARNING:LINE_SPACING: Missing a blank line after declarations #73: FILE: drivers/gpu/drm/i915/display/intel_display.c:173: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.compute_pipe_wm) -:82: WARNING:LINE_SPACING: Missing a blank line after declarations #82: FILE: drivers/gpu/drm/i915/display/intel_display.c:182: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (!dev_priv->display.compute_intermediate_wm) -:94: WARNING:LINE_SPACING: Missing a blank line after declarations #94: FILE: drivers/gpu/drm/i915/display/intel_display.c:194: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.initial_watermarks) { -:105: WARNING:LINE_SPACING: Missing a blank line after declarations #105: FILE: drivers/gpu/drm/i915/display/intel_display.c:205: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.atomic_update_watermarks) -:113: WARNING:LINE_SPACING: Missing a blank line after declarations #113: FILE: drivers/gpu/drm/i915/display/intel_display.c:213: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.optimize_watermarks) -:120: WARNING:LINE_SPACING: Missing a blank line after declarations #120: FILE: drivers/gpu/drm/i915/display/intel_display.c:220: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + if (dev_priv->display.compute_global_watermarks) -:134: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20) #134: FILE: drivers/gpu/drm/i915/display/intel_display.c:2626: + if (!intel_initial_watermarks(state, crtc)) + if (new_crtc_state->update_wm_pre) -:135: WARNING:TABSTOP: Statements should start on a tabstop #135: FILE: drivers/gpu/drm/i915/display/intel_display.c:2627: + if (new_crtc_state->update_wm_pre) -:176: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #176: FILE: drivers/gpu/drm/i915/display/intel_display.c:3670: + if (!intel_initial_watermarks(state, crtc)) + intel_update_watermarks(dev_priv); total: 0 errors, 10 warnings, 1 checks, 319 lines checked 3244c7d3e7de drm/i915: add wrappers around cdclk vtable funcs. -:32: WARNING:LINE_SPACING: Missing a blank line after declarations #32: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:71: + struct drm_i915_private *dev_priv = to_i915(state->base.dev); + return dev_priv->display.bw_calc_min_cdclk(state); total: 0 errors, 1 warnings, 0 checks, 127 lines checked 674574afea70 drm/i915/display: add intel_fdi_link_train wrapper. 1fca45b59ad3 drm/i915: split clock gating init from display vtable 6dd5d455c1a0 drm/i915: split watermark vfuncs from display vtable. 6935719a9688 drm/i915: split color functions from display vtable fdbf1f460624 drm/i915: split audio functions from display vtable 9c1f3f3d3646 drm/i915: split cdclk functions from display vtable. acdcc485829c drm/i915: split irq hotplug function from display vtable a8affbd54af5 drm/i915: split fdi link training from display vtable. 2fa341dd4959 drm/i915: split the dpll clock compute out from display vtable. 2a07ef7ab0a4 drm/i915: constify fdi link training vtable 8f81d15f47fb drm/i915: constify hotplug function vtable. 4a6c7e4d8f47 drm/i915: constify color function vtable. -:197: CHECK:BRACES: Unbalanced braces around else statement #197: FILE: drivers/gpu/drm/i915/display/intel_color.c:2194: + } else total: 0 errors, 0 warnings, 1 checks, 187 lines checked 279b30727870 drm/i915: constify the audio function vtable 4cf7d1ee6422 drm/i915: constify the dpll clock vtable ae656f5302b5 drm/i915: constify the cdclk vtable 2a79c0876663 drm/i915: drop unused function ptr and comments. 43df9f5fd78c drm/i915: constify display function vtable 1c6f686f0ff9 drm/i915: constify clock gating init vtable. 0b9853442fd8 drm/i915: constify display wm vtable
