On Mon, 2021-09-13 at 16:27 +0530, Gupta, Anshuman wrote: > > > > -----Original Message----- > > From: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx> > > Sent: Friday, September 10, 2021 11:15 PM > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; Daniel Vetter > > <daniel.vetter@xxxxxxxx>; David Weinehall > > <david.weinehall@xxxxxxxxxxxxxxx>; > > Tangudu, Tilak <tilak.tangudu@xxxxxxxxx>; Deak, Imre > > <imre.deak@xxxxxxxxx>; > > Gupta, Anshuman <anshuman.gupta@xxxxxxxxx> > > Subject: [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by > > default > > > > Let's enable runtime pm autosuspend by default everywhere. > > > > But at this time let's not touch the autosuspend_delay time, what > > caused some > > regression on our previous attempt. > > > > v2: CI on some gen9 platforms was not clean. But it came > > pretty clean on newer generations. For now, let's > > pick gen12 and newer. We will return later to extend > > that to older platforms. > > > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Cc: David Weinehall <david.weinehall@xxxxxxxxxxxxxxx> > > Cc: Tilak Tangudu <tilak.tangudu@xxxxxxxxx> > > Cc: Imre Deak <imre.deak@xxxxxxxxx> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > Reviewed-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx> #v1 > > --- > > drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > > b/drivers/gpu/drm/i915/intel_runtime_pm.c > > index f28b5bab61b4..f91a04c3ef14 100644 > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > > @@ -605,6 +605,10 @@ void intel_runtime_pm_enable(struct > > intel_runtime_pm *rpm) > > pm_runtime_use_autosuspend(kdev); > > } > > > > + /* XXX: Enable by default only for newer platforms for now > > */ > > + if (GRAPHICS_VER(i915) >= 12) > > + pm_runtime_allow(kdev); > Reviewed-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx> > Looks good to me. > Br, > Anshuman Gupta. Not so fast though :( We found some bugs on DG2. Tilak will take a look there before we can push this. Thanks, Rodrigo. > > + > > /* > > * The core calls the driver load handler with an RPM > > reference held. > > * We drop that here and will reacquire it during unloading > > in > > -- > > 2.31.1 >
