== Series Details == Series: i915: Simplify mmio handling & add new DG2 shadow table URL : https://patchwork.freedesktop.org/series/94534/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9184ecd8873a drm/i915/uncore: Convert gen6/gen7 read operations to fwtable 2d9ea1a952fa drm/i915/uncore: Associate shadow table with uncore -:42: CHECK:LINE_SPACING: Please don't use multiple blank lines #42: FILE: drivers/gpu/drm/i915/intel_uncore.c:1051: + -:86: CHECK:LINE_SPACING: Please don't use multiple blank lines #86: FILE: drivers/gpu/drm/i915/intel_uncore.c:1720: + -:94: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #94: FILE: drivers/gpu/drm/i915/intel_uncore.c:1985: +#define ASSIGN_SHADOW_TABLE(uncore, d) \ +{ \ + (uncore)->shadowed_reg_table = d; \ + (uncore)->shadowed_reg_table_entries = ARRAY_SIZE((d)); \ +} -:94: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects? #94: FILE: drivers/gpu/drm/i915/intel_uncore.c:1985: +#define ASSIGN_SHADOW_TABLE(uncore, d) \ +{ \ + (uncore)->shadowed_reg_table = d; \ + (uncore)->shadowed_reg_table_entries = ARRAY_SIZE((d)); \ +} total: 0 errors, 0 warnings, 4 checks, 128 lines checked 2a61c25b475a drm/i915/uncore: Replace gen8 write functions with general fwtable 60268645b0c1 drm/i915/uncore: Drop gen11/gen12 mmio write handlers bc9eef9ef981 drm/i915/uncore: Drop gen11 mmio read handlers -:39: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #39: FILE: drivers/gpu/drm/i915/intel_uncore.c:1572: +#define __gen_fwtable_read(x) \ static u##x \ +fwtable_read##x(struct intel_uncore *uncore, i915_reg_t reg, bool trace) \ +{ \ enum forcewake_domains fw_engine; \ GEN6_READ_HEADER(x); \ + fw_engine = __fwtable_reg_read_fw_domains(uncore, offset); \ if (fw_engine) \ __force_wake_auto(uncore, fw_engine); \ val = __raw_uncore_read##x(uncore, reg); \ GEN6_READ_FOOTER; \ } -:64: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #64: FILE: drivers/gpu/drm/i915/intel_uncore.c:1585: +static enum forcewake_domains +fwtable_reg_read_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { total: 2 errors, 0 warnings, 0 checks, 86 lines checked 2c15e729f1d8 drm/i915/dg2: Add DG2-specific shadow register table
