== Series Details == Series: Enable GuC submission by default on DG1 (rev3) URL : https://patchwork.freedesktop.org/series/93325/ State : warning == Summary == $ dim checkpatch origin/drm-tip b8e27e3106db drm/i915: Do not define vma on stack b62cec27d5a5 drm/i915/guc: put all guc objects in lmem when available a6a716178ac4 drm/i915/guc: Add DG1 GuC / HuC firmware defs cf65ce8f5f7d drm/i915/guc: Enable GuC submission by default on DG1 e215cd9a6cd0 Me: Allow relocs on DG1 for CI -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 1 warnings, 0 checks, 8 lines checked 9cda72a501d1 Me: Workaround LMEM blow up -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 1 warnings, 0 checks, 8 lines checked b8328abe386c Me: Dump GuC log to dmesg on SLPC load failure -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:17: CHECK:SPACING: No space is necessary after a cast #17: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:267: + (intel_engine_mask_t) ~0U); -:56: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #56: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1999: + if (!buf) { + drm_err(&i915->drm, "Failed to allocate buffer for error capture!\n"); -:68: WARNING:LINE_SPACING: Missing a blank line after declarations #68: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2011: + ssize_t got = i915_gpu_coredump_copy_to_buffer(error, buf, pos_err, buf_size - 1); + if (got <= 0) -:91: CHECK:BRACES: braces {} should be used on all arms of this statement #91: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2034: + if (count > MAX_CHUNK) { [...] + } else [...] -:97: WARNING:LINE_SPACING: Missing a blank line after declarations #97: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2040: + char chr = ptr[pos]; + ptr[pos] = 0; -:104: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #104: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2047: + drm_info(&i915->drm, "Capture %c%s%c\n", tag[0], ptr2, tag[1]); -:107: CHECK:BRACES: Unbalanced braces around else statement #107: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:2050: + } else -:139: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 5 warnings, 3 checks, 118 lines checked 39547aae072e drm/i915: Get PM ref before accessing HW register