On Mon, Aug 30, 2021 at 09:52:40PM +0530, Ayaz A Siddiqui wrote: > Some platform like XEHPSVD does not have Renderer engines. since > read_l3cc_table() is guarded by renderer class due to that check > of L3CC table was not being performed on those platforms. > > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/selftest_mocs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_mocs.c b/drivers/gpu/drm/i915/gt/selftest_mocs.c > index 2b0207dfbf21c..05f5c57f82699 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_mocs.c > +++ b/drivers/gpu/drm/i915/gt/selftest_mocs.c > @@ -281,7 +281,7 @@ static int check_mocs_engine(struct live_mocs *arg, > offset = i915_ggtt_offset(vma); > if (!err) > err = read_mocs_table(rq, arg->mocs, &offset); > - if (!err && ce->engine->class == RENDER_CLASS) > + if (!err) This is going to make us read & verify the same values several times (once per engine) which doesn't seem to provide much benefit. But I guess we do the same thing for global MOCS and nobody seems to care about the duplicated effort there either. I guess it doesn't really matter. Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx> Matt > err = read_l3cc_table(rq, arg->l3cc, &offset); > if (!err) > err = read_aux_regs(rq, aux, &offset); > @@ -296,7 +296,7 @@ static int check_mocs_engine(struct live_mocs *arg, > vaddr = arg->vaddr; > if (!err) > err = check_mocs_table(ce->engine, arg->mocs, &vaddr); > - if (!err && ce->engine->class == RENDER_CLASS) > + if (!err) > err = check_l3cc_table(ce->engine, arg->l3cc, &vaddr); > if (!err) > err = check_aux_regs(ce->engine, aux, &vaddr); > -- > 2.26.2 > -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
