Re: [PATCH v10 03/11] drm/ttm: Add a generic TTM memcpy move for page-based iomem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

On 8/30/21 8:16 AM, Christian König wrote:
Am 30.08.21 um 03:54 schrieb Dave Airlie:
I've just been talking with Ben about nouveau having some issues since
this path,

ttm_resource can be subclassed by drivers, and the code below that
copies ttm_resources around pretty much seems to destroy that.


+       struct ttm_resource *src_mem = &bo->mem;
+       struct ttm_resource_manager *src_man =
+               ttm_manager_type(bdev, src_mem->mem_type);
+       struct ttm_resource src_copy = *src_mem;
This here ^^

Mhm, that's most likely a rebase/merge conflict between my change to subclass ttm_resource which came in through the drm-misc-next tree and Thomas change here.

Thomas can you take a look?

Thanks,
Christian.

Posted a patch.

Ben, it would be great if you could help give it a try to verify that it works. I'll give it a try on vmwgfx later today if I can get it running. Looks like VMware mesa is broken on Fedora..

/Thomas





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux