On Wed, 25 Aug 2021, Lyude Paul <lyude@xxxxxxxxxx> wrote: > Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx> (assuming this still applies) > > As I mentioned on IRC pretty much all of the DPCD backlight helpers already > made it upstream. There are some changes I'm working on right now for VESA > backlights that use PWM for controlling the brightness level (so we can > hopefully fix https://gitlab.freedesktop.org/drm/intel/-/issues/3680 , > otherwise I've gotta do some more poking with the backlight folks from Intel I > got in touch with), but I have no problem with rebasing this when the time > comes. Thanks! BR, Jani. > > On Wed, 2021-08-25 at 14:06 +0300, Jani Nikula wrote: >> Extract the backlight code out of intel_panel.c, and rename the panel >> and backlight functions according to usual conventions. >> >> Lyude, I haven't seen follow-ups on the DPCD backlight stuff you've >> worked on. Is it okay to merge this (and inevitably cause you conflicts) >> or shall I wait more? >> >> BR, >> Jani. >> >> >> Cc: Lyude Paul <lyude@xxxxxxxxxx> >> >> Jani Nikula (3): >> drm/i915/backlight: extract backlight code to a separate file >> drm/i915/backlight: mass rename functions to have intel_backlight_ >> prefix >> drm/i915/panel: mass rename functions to have intel_panel_ prefix >> >> drivers/gpu/drm/i915/Makefile | 1 + >> drivers/gpu/drm/i915/display/g4x_dp.c | 4 +- >> drivers/gpu/drm/i915/display/icl_dsi.c | 13 +- >> .../gpu/drm/i915/display/intel_backlight.c | 1776 ++++++++++++++++ >> .../gpu/drm/i915/display/intel_backlight.h | 52 + >> .../gpu/drm/i915/display/intel_connector.c | 4 +- >> drivers/gpu/drm/i915/display/intel_ddi.c | 4 +- >> drivers/gpu/drm/i915/display/intel_dp.c | 16 +- >> .../drm/i915/display/intel_dp_aux_backlight.c | 12 +- >> drivers/gpu/drm/i915/display/intel_dvo.c | 2 +- >> drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- >> drivers/gpu/drm/i915/display/intel_lvds.c | 18 +- >> drivers/gpu/drm/i915/display/intel_opregion.c | 5 +- >> drivers/gpu/drm/i915/display/intel_panel.c | 1786 +---------------- >> drivers/gpu/drm/i915/display/intel_panel.h | 42 +- >> drivers/gpu/drm/i915/display/vlv_dsi.c | 16 +- >> 16 files changed, 1895 insertions(+), 1858 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/display/intel_backlight.c >> create mode 100644 drivers/gpu/drm/i915/display/intel_backlight.h >> -- Jani Nikula, Intel Open Source Graphics Center
