On Tue, 24 Aug 2021, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > On Mon, Aug 23, 2021 at 03:25:30PM +0300, Jani Nikula wrote: >> Make some forward progress on reducing intel_display.c size. >> >> Jani Nikula (6): >> drm/i915/display: split out dpt out of intel_display.c >> drm/i915: add HAS_ASYNC_FLIPS feature macro >> drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c >> drm/i915/fb: move intel_fb_align_height() to intel_fb.c >> drm/i915/fb: move intel_surf_alignment() to intel_fb.c >> drm/i915/fb: move user framebuffer stuff to intel_fb.c >> >> drivers/gpu/drm/i915/Makefile | 1 + >> drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------ >> drivers/gpu/drm/i915/display/intel_display.h | 6 - >> drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++ >> drivers/gpu/drm/i915/display/intel_dpt.h | 19 + >> drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++ >> drivers/gpu/drm/i915/display/intel_fb.h | 20 +- >> drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + >> drivers/gpu/drm/i915/i915_drv.h | 2 + >> 9 files changed, 752 insertions(+), 716 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c >> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h > > I believe it would be good to add a /** DOC: */ or at least > a simple comment block explaining a bit what DPT is. I agree, but I'm not signing up for that! > But other than that the series looks good, so, up to you: > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > (for the series) Thanks, Jani > >> >> -- >> 2.20.1 >> -- Jani Nikula, Intel Open Source Graphics Center
