> -----Original Message----- > From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Sent: Friday, August 13, 2021 1:25 PM > To: Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx>; Siddiqui, Ayaz A > <ayaz.siddiqui@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: > Initialize unused MOCS entries to L3_WB > > > These are all valid warnings, please fix. > > BR, > Jani, Thanks Jani, I have fixed all the warning in v2, it was due to region that in my local Patch check is not using --stict option . -Ayaz > > > On Thu, 12 Aug 2021, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> > wrote: > > == Series Details == > > > > Series: drm/i915/gt: Initialize unused MOCS entries to L3_WB > > URL : https://patchwork.freedesktop.org/series/93626/ > > State : warning > > > > == Summary == > > > > $ dim checkpatch origin/drm-tip > > ea863ae02268 drm/i915/gt: Add support of mocs propagation > > -:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #55: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:511: > > +static void set_mocs_index(struct intel_gt *gt, > > + struct drm_i915_mocs_table *table) > > > > total: 0 errors, 0 warnings, 1 checks, 44 lines checked ee1214c8eb4d > > drm/i915/gt: Use cmd_cctl override for platforms >= gen12 > > -:85: ERROR:CODE_INDENT: code indent should use tabs where possible > > #85: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:394: > > +^I "Platform that should have UC index defined and does > not\n")) {$ > > > > -:189: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses > around 'masked_value != expect' > > #189: FILE: drivers/gpu/drm/i915/gt/selftest_mocs.c:185: > > + if (!r->skip_check && (masked_value != expect)) { > > > > total: 1 errors, 0 warnings, 1 checks, 235 lines checked fd32a98d8b4f > > drm/i915/gt: Set BLIT_CCTL reg to un-cached > > -:61: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dst' may be > better > > as '(dst)' to avoid precedence issues > > #61: FILE: drivers/gpu/drm/i915/i915_reg.h:2574: > > +#define BLIT_CCTL_MOCS(dst, src) > \ > > + (((dst << 1) << BLIT_CCTL_DST_MOCS_SHIFT) | (src << 1)) > > > > -:61: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'src' may be > better > > as '(src)' to avoid precedence issues > > #61: FILE: drivers/gpu/drm/i915/i915_reg.h:2574: > > +#define BLIT_CCTL_MOCS(dst, src) > \ > > + (((dst << 1) << BLIT_CCTL_DST_MOCS_SHIFT) | (src << 1)) > > > > total: 0 errors, 0 warnings, 2 checks, 38 lines checked > > 702829c25d98 drm/i915/gt: Initialize unused MOCS entries with device > > specific values 4f3306739a7e drm/i95/adl: Define MOCS table for > > Alderlake > > -:22: CHECK:LINE_SPACING: Please use a blank line after > > function/struct/union/enum declarations > > #22: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:325: > > }; > > +static const struct drm_i915_mocs_entry adl_mocs_table[] = { > > > > -:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #25: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:328: > > + MOCS_ENTRY(0, > > + LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), > > > > -:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #31: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:334: > > + MOCS_ENTRY(48, > > + LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), > > > > -:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #35: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:338: > > + MOCS_ENTRY(49, > > + LE_1_UC | LE_TC_1_LLC, > > > > -:39: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #39: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:342: > > + MOCS_ENTRY(50, > > + LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), > > > > -:43: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #43: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:346: > > + MOCS_ENTRY(51, > > + LE_1_UC | LE_TC_1_LLC, > > > > -:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #47: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:350: > > + MOCS_ENTRY(60, > > + LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), > > > > -:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > > parenthesis > > #51: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:354: > > + MOCS_ENTRY(61, > > + LE_1_UC | LE_TC_1_LLC, > > > > total: 0 errors, 0 warnings, 8 checks, 52 lines checked > > > > > > -- > Jani Nikula, Intel Open Source Graphics Center
