== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev4) URL : https://patchwork.freedesktop.org/series/93415/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0d891258e40a drm/sched: Split drm_sched_job_init -:240: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #240: FILE: drivers/gpu/drm/scheduler/sched_fence.c:173: + unsigned seq; -:336: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #336: FILE: drivers/gpu/drm/scheduler/sched_main.c:623: + BUG_ON(!entity); -:405: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #405: FILE: include/drm/gpu_scheduler.h:391: +struct drm_sched_fence *drm_sched_fence_alloc( -:413: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 3 warnings, 1 checks, 248 lines checked 27dbe1a630f0 drm/msm: Improve drm/sched point of no return rules -:78: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 37 lines checked 5b5164ff17f2 drm/sched: Barriers are needed for entity->last_scheduled -:88: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 43 lines checked 255f53586a60 drm/sched: Add dependency tracking -:195: CHECK:LINE_SPACING: Please don't use multiple blank lines #195: FILE: drivers/gpu/drm/scheduler/sched_main.c:729: + + -:271: WARNING:TYPO_SPELLING: 'ommitted' may be misspelled - perhaps 'omitted'? #271: FILE: include/drm/gpu_scheduler.h:244: + * drm_sched_job_add_implicit_dependencies() this can be ommitted and ^^^^^^^^ -:286: CHECK:LINE_SPACING: Please don't use multiple blank lines #286: FILE: include/drm/gpu_scheduler.h:378: + + -:289: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 2 checks, 230 lines checked ebfbb6077485 drm/sched: drop entity parameter from drm_sched_push_job -:228: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 110 lines checked f4b4e005b964 drm/sched: improve docs around drm_sched_entity -:17: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 620e762f9a98 ("drm/scheduler: move entity handling into separate file")' #17: move here: 620e762f9a98 ("drm/scheduler: move entity handling into -:413: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 346 lines checked 6687763f729e drm/panfrost: use scheduler dependency tracking -:215: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 158 lines checked ca1c5aec7cde drm/lima: use scheduler dependency tracking -:119: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 75 lines checked 1663a9467a04 drm/v3d: Move drm_sched_job_init to v3d_job_init -:344: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 288 lines checked 2c445c2eb7fe drm/v3d: Use scheduler dependency handling -:207: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 162 lines checked e63e89cc8ac5 drm/etnaviv: Use scheduler dependency handling -:13: WARNING:REPEATED_WORD: Possible repeated word: 'to' #13: I wanted to to in the previous round (and did, for all other drivers). -:122: WARNING:LINE_SPACING: Missing a blank line after declarations #122: FILE: drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:552: + struct dma_fence *in_fence = sync_file_get_fence(args->fence_fd); + if (!in_fence) { -:297: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 3 warnings, 0 checks, 243 lines checked 9f2a9ecfea9c drm/msm: Use scheduler dependency handling -:132: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 90 lines checked e5b7840798ca drm/gem: Delete gem array fencing helpers -:141: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked 8f51a69d4e74 drm/sched: Don't store self-dependencies -:19: WARNING:TYPO_SPELLING: 'wont' may be misspelled - perhaps 'won't'? #19: drivers wont miss it. ^^^^ -:47: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 13 lines checked 7650a6f74b18 drm/sched: Check locking in drm_sched_job_await_implicit -:33: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 8 lines checked a3c9153955a4 drm/msm: Don't break exclusive fence ordering -:43: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 9 lines checked 2eb5ca447466 drm/etnaviv: Don't break exclusive fence ordering -:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #20: https://lore.kernel.org/dri-devel/20210610210925.642582-7-jason@xxxxxxxxxxxxxx/ -:58: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 24 lines checked ab0a3f52cac3 drm/i915: delete exclude argument from i915_sw_fence_await_reservation -:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d07f0e59b2c7 ("drm/i915: Move GEM activity tracking into a common struct reservation_object")' #12: commit d07f0e59b2c762584478920cd2d11fba2980a94a -:100: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 55 lines checked 8c4011c29394 drm/i915: Don't break exclusive fence ordering -:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #23: https://lore.kernel.org/dri-devel/20210610210925.642582-7-jason@xxxxxxxxxxxxxx/ -:56: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 18 lines checked 724ee6ec9713 dma-resv: Give the docs a do-over -:290: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 216 lines checked
