On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@xxxxxxxxx> wrote:
> On 13-Aug-21 1:16 PM, Jani Nikula wrote:
>> On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@xxxxxxxxx> wrote:
>>> drm_dp_dpcd_read/write already has debug error message.
>>> Drop redundant error messages which gives false
>>> status even if correct value is read in drm_dp_dpcd_read().
>>
>> I guess the only problem is it gets harder to associate the preceding
>> low level error messages with intel_dp_check_link_service_irq(). *shrug*
>>
>> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>>
>>
> Thanks Jani for the review. Can you please merge?
There was another version with open review?
BR,
Jani.
>
>>>
>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>>> Cc: Swati Sharma <swati2.sharma@xxxxxxxxx>
>>> Cc: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>
>>> Cc: Uma Shankar <uma.shankar@xxxxxxxxx> (v2)
>>> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
>>> Cc: "Ville Syrj_l_" <ville.syrjala@xxxxxxxxxxxxxxx>
>>> Cc: Imre Deak <imre.deak@xxxxxxxxx>
>>> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
>>> Cc: Uma Shankar <uma.shankar@xxxxxxxxx>
>>> Cc: "Jos_ Roberto de Souza" <jose.souza@xxxxxxxxx>
>>> Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
>>> Cc: <stable@xxxxxxxxxxxxxxx> # v5.12+
>>>
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@xxxxxxxxx
>>> Signed-off-by: Swati Sharma <swati2.sharma@xxxxxxxxx>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
>>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index c386ef8eb200..5c84f51ad41d 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>>> return;
>>>
>>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>>> return;
>>> - }
>>>
>>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>>> return;
>>> - }
>>>
>>> if (val & HDMI_LINK_STATUS_CHANGED)
>>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>>
--
Jani Nikula, Intel Open Source Graphics Center
