Re: [PATCH] drm/i915: Use Transparent Hugepages when IOMMU is enabled

[kernel test robot <lkp@xxxxxxxxx>]

Hi Tvrtko,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tvrtko-Ursulin/drm-i915-Use-Transparent-Hugepages-when-IOMMU-is-enabled/20210728-221515
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a015-20210728 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/26ad4b5023a428526c23ce544b593eced1916b49
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tvrtko-Ursulin/drm-i915-Use-Transparent-Hugepages-when-IOMMU-is-enabled/20210728-221515
        git checkout 26ad4b5023a428526c23ce544b593eced1916b49
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/gem/i915_gemfs.c: In function 'i915_gemfs_init':
>> drivers/gpu/drm/i915/gem/i915_gemfs.c:16:30: error: expected ',' or ';' before 'CONFIG_DRM_I915_THP_NATIVE'
      16 |  char thp_native[] = "huge=" CONFIG_DRM_I915_THP_NATIVE;
         |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gem/i915_gemfs.c:17:29: error: expected ',' or ';' before 'CONFIG_DRM_I915_THP_IOMMU'
      17 |  char thp_iommu[] = "huge=" CONFIG_DRM_I915_THP_IOMMU;
         |                             ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +16 drivers/gpu/drm/i915/gem/i915_gemfs.c

    13	
    14	int i915_gemfs_init(struct drm_i915_private *i915)
    15	{
  > 16		char thp_native[] = "huge=" CONFIG_DRM_I915_THP_NATIVE;
  > 17		char thp_iommu[] = "huge=" CONFIG_DRM_I915_THP_IOMMU;
    18		struct file_system_type *type;
    19		struct vfsmount *gemfs;
    20		char *opts;
    21	
    22		type = get_fs_type("tmpfs");
    23		if (!type)
    24			return -ENODEV;
    25	
    26		/*
    27		 * By creating our own shmemfs mountpoint, we can pass in
    28		 * mount flags that better match our usecase.
    29		 *
    30		 * One example, although it is probably better with a per-file
    31		 * control, is selecting huge page allocations ("huge=within_size").
    32		 * However, we only do so to offset the overhead of iommu lookups
    33		 * due to bandwidth issues (slow reads) on Broadwell+.
    34		 */
    35		opts = intel_vtd_active() ? thp_iommu : thp_native;
    36	
    37		gemfs = vfs_kern_mount(type, SB_KERNMOUNT, type->name, opts);
    38		if (IS_ERR(gemfs))
    39			return PTR_ERR(gemfs);
    40	
    41		i915->mm.gemfs = gemfs;
    42	
    43		drm_info(&i915->drm, "Transparent Hugepage mode '%s'", opts);
    44	
    45		return 0;
    46	}
    47	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip